lkml.org 
[lkml]   [2022]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] LoongArch: drop these obsolete selects in Kconfig
From
On 2022/7/5 15:34, Lukas Bulwahn wrote:
> Commit fa96b57c1490 ("LoongArch: Add build infrastructure") adds the new
> file arch/loongarch/Kconfig.
>
> As the work on LoongArch was probably quite some time under development,
> various config symbols have changed and disappeared from the time of
> initial writing of the Kconfig file and its inclusion in the repository.
>
> The following four commits:
>
> commit c126a53c2760 ("arch: remove GENERIC_FIND_FIRST_BIT entirely")
> commit 140c8180eb7c ("arch: remove HAVE_COPY_THREAD_TLS")
> commit aca52c398389 ("mm: remove CONFIG_HAVE_MEMBLOCK")
> commit 3f08a302f533 ("mm: remove CONFIG_HAVE_MEMBLOCK_NODE_MAP option")
>
> remove the mentioned config symbol, and enable the intended setup by
> default without configuration.
>
> Drop these obsolete selects in loongarch's Kconfig.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Huacai Chen, please pick this minor clean-up patch.
>
> arch/loongarch/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index 2dee595bf4b6..9be4d0eef299 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -54,7 +54,6 @@ config LOONGARCH
> select GENERIC_CMOS_UPDATE
> select GENERIC_CPU_AUTOPROBE
> select GENERIC_ENTRY
> - select GENERIC_FIND_FIRST_BIT
> select GENERIC_GETTIMEOFDAY
> select GENERIC_IRQ_MULTI_HANDLER
> select GENERIC_IRQ_PROBE
> @@ -77,7 +76,6 @@ config LOONGARCH
> select HAVE_ARCH_TRANSPARENT_HUGEPAGE
> select HAVE_ASM_MODVERSIONS
> select HAVE_CONTEXT_TRACKING_USER
> - select HAVE_COPY_THREAD_TLS
> select HAVE_DEBUG_STACKOVERFLOW
> select HAVE_DMA_CONTIGUOUS
> select HAVE_EXIT_THREAD
> @@ -86,8 +84,6 @@ config LOONGARCH
> select HAVE_IOREMAP_PROT
> select HAVE_IRQ_EXIT_ON_IRQ_STACK
> select HAVE_IRQ_TIME_ACCOUNTING
> - select HAVE_MEMBLOCK
> - select HAVE_MEMBLOCK_NODE_MAP
> select HAVE_MOD_ARCH_SPECIFIC
> select HAVE_NMI
> select HAVE_PERF_EVENTS

Looks good to me, thanks for the cleanup!

Reviewed-by: WANG Xuerui <git@xen0n.name>

\
 
 \ /
  Last update: 2022-07-05 10:35    [W:0.051 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site