lkml.org 
[lkml]   [2022]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject答复: [PATCH net-next] net/sched: remove retu rn value of unregister tcf proto ops
    Date

    -----邮件原件-----
    发件人: Jakub Kicinski [mailto:kuba@kernel.org]
    发送时间: 2022年7月6日 9:43
    收件人: shaozhengchao <shaozhengchao@huawei.com>
    抄送: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; jhs@mojatatu.com; xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; weiyongjun (A) <weiyongjun1@huawei.com>; yuehaibing <yuehaibing@huawei.com>
    主题: Re: [PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops

    On Mon, 4 Jul 2022 20:43:22 +0800 Zhengchao Shao wrote:
    > Return value of unregister_tcf_proto_ops is useless, remove it.

    s/useless/unused/ ?

    Should we add a WARN if the ops getting removed can't be found or there are callers which depend on handling unregistered ops without a warning?

    Hi Jakub Kicinski:
    Thank you for your apply. This patch does just remove the return value and change the function type from int to void. It doesn't remove the function.

    Zhengchao Shao
    \
     
     \ /
      Last update: 2022-07-06 03:53    [W:2.823 / U:1.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site