lkml.org 
[lkml]   [2022]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND v5 7/8] clk: baikal-t1: Add DDR/PCIe directly controlled resets support
Hi Philipp

On Wed, Jun 29, 2022 at 05:16:56PM +0200, Philipp Zabel wrote:
> Hi Serge,
>
> On Fr, 2022-06-24 at 17:18 +0300, Serge Semin wrote:
> > Aside with a set of the trigger-like resets Baikal-T1 CCU provides two
> > additional blocks with directly controlled reset signals. In particular it
> > concerns DDR full and initial resets and various PCIe sub-domains resets.
> > Let's add the direct reset assertion/de-assertion of the corresponding
> > flags support into the Baikal-T1 CCU driver then. It will be required at
> > least for the PCIe platform driver. Obviously the DDR controller isn't
> > supposed to be fully reset in the kernel, so the corresponding controls
> > are added just for the sake of the interface implementation completeness.
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>

> This looks good to me, the issues with the previous patch still apply.

I see. Let's settle the main question there first then. Further
actions in this patch framework depend on your answer there.

-Sergey

>
> [...]
> > +static int ccu_rst_set(struct reset_controller_dev *rcdev,
> > + unsigned long idx, bool high)
> > +{
> > + struct ccu_rst *rst;
> > +
> > + rst = ccu_rst_get_desc(rcdev, idx);
> > + if (IS_ERR(rst)) {
> > + pr_err("Invalid reset index %lu specified\n", idx);
> > + return PTR_ERR(rst);
> > + }
>
> e.g. this should not be necessary.
>
> regards
> Philipp

\
 
 \ /
  Last update: 2022-07-06 00:12    [W:2.435 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site