Messages in this thread | | | Subject | Re: [PATCH v7 0/4] tracing/probes: allow no event name input when create group | From | Tom Zanussi <> | Date | Tue, 05 Jul 2022 16:46:32 -0500 |
| |
Hi Yuan,
On Mon, 2022-06-27 at 10:19 +0800, Linyu Yuan wrote: > take kprobe event as example, when create a group of events, > p[:[GRP/]EVENT] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS], > according to this format, we must input EVENT name, > > this change allow only GRP/ input, EVENT name auto generate from > KSYM, > p[:[GRP/][EVENT]] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS] > > similar change apply to eprobe and uprobe.
Thanks for making those changes!
For the series,
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
Tom
> > V2: (v1: > https://lore.kernel.org/lkml/1651397651-30454-1-git-send-email-quic_linyyuan@quicinc.com/ > ) > fix remove comment in V1 patch1, > remove v1 patch2 as it is NACK. > > v3: (v2 : > https://lore.kernel.org/lkml/1653795294-19764-1-git-send-email-quic_linyyuan@quicinc.com/ > ) > add selftest cases for kprobe and eprobe event, > remove macro used in v1,v2, > change location to generate eprobe event name. > > v4: (v3 : > https://lore.kernel.org/lkml/1653978552-18637-1-git-send-email-quic_linyyuan@quicinc.com/ > ) > fix comment of kprobe/eprobe test case. > > v5: (v4: > https://lore.kernel.org/lkml/1654171861-24014-1-git-send-email-quic_linyyuan@quicinc.com/ > ) > for eprobe, when only input a "SYSTEM.", it is invalid. > add Acked-by from Masami Hiramatsu (Google) <mhiramat@kernel.org> > > v6: (v5: > https://lore.kernel.org/lkml/1655168698-19898-1-git-send-email-quic_linyyuan@quicinc.com/ > ) > change some code order according review comment from Tom Zanussi, > some minor changes. > > v7: (v6: > https://lore.kernel.org/lkml/1655776787-18133-1-git-send-email-quic_linyyuan@quicinc.com/ > ) > move log index to a separate patch according review comment > > Linyu Yuan (4): > tracing: eprobe: add missing log index > tracing: eprobe: remove duplicate is_good_name() operation > tracing: auto generate event name when create a group of events > selftests/ftrace: add test case for GRP/ only input > > Documentation/trace/kprobetrace.rst | 8 +++---- > Documentation/trace/uprobetracer.rst | 8 +++---- > kernel/trace/trace.c | 8 +++---- > kernel/trace/trace_dynevent.c | 2 +- > kernel/trace/trace_eprobe.c | 28 +++++++++++- > ---------- > kernel/trace/trace_kprobe.c | 16 ++++++++---- > - > kernel/trace/trace_probe.c | 4 ++++ > kernel/trace/trace_uprobe.c | 12 ++++++---- > .../ftrace/test.d/dynevent/add_remove_eprobe.tc | 9 ++++++- > .../ftrace/test.d/dynevent/add_remove_kprobe.tc | 7 ++++++ > 10 files changed, 64 insertions(+), 38 deletions(-) >
| |