Messages in this thread | | | Date | Wed, 6 Jul 2022 05:20:32 +0800 | From | kernel test robot <> | Subject | [ammarfaizi2-block:brauner/linux/fs.idmapped.overlay.acl.fix 1/1] fs/overlayfs/overlayfs.h:273:65: warning: passing argument 4 of 'ovl_do_setxattr' discards 'const' qualifier from pointer target type |
| |
tree: https://github.com/ammarfaizi2/linux-block brauner/linux/fs.idmapped.overlay.acl.fix head: b74b8feea72cd6eda1f0b673de658db30ca15e7a commit: b74b8feea72cd6eda1f0b673de658db30ca15e7a [1/1] acl: report correct ownership in some ovl use-cases config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220706/202207060501.jrxLX8Kn-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/ammarfaizi2/linux-block/commit/b74b8feea72cd6eda1f0b673de658db30ca15e7a git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block brauner/linux/fs.idmapped.overlay.acl.fix git checkout b74b8feea72cd6eda1f0b673de658db30ca15e7a # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from fs/overlayfs/dir.c:17: fs/overlayfs/overlayfs.h: In function 'ovl_setxattr': >> fs/overlayfs/overlayfs.h:273:65: warning: passing argument 4 of 'ovl_do_setxattr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 273 | return ovl_do_setxattr(ofs, dentry, ovl_xattr(ofs, ox), value, size, 0); | ^~~~~ fs/overlayfs/overlayfs.h:259:59: note: expected 'void *' but argument is of type 'const void *' 259 | const char *name, void *value, | ~~~~~~^~~~~ -- In file included from fs/overlayfs/inode.c:17: fs/overlayfs/overlayfs.h: In function 'ovl_setxattr': >> fs/overlayfs/overlayfs.h:273:65: warning: passing argument 4 of 'ovl_do_setxattr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 273 | return ovl_do_setxattr(ofs, dentry, ovl_xattr(ofs, ox), value, size, 0); | ^~~~~ fs/overlayfs/overlayfs.h:259:59: note: expected 'void *' but argument is of type 'const void *' 259 | const char *name, void *value, | ~~~~~~^~~~~ fs/overlayfs/inode.c: In function 'ovl_xattr_set': >> fs/overlayfs/inode.c:378:62: warning: passing argument 4 of 'ovl_do_setxattr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 378 | err = ovl_do_setxattr(ofs, realdentry, name, value, size, | ^~~~~ In file included from fs/overlayfs/inode.c:17: fs/overlayfs/overlayfs.h:259:59: note: expected 'void *' but argument is of type 'const void *' 259 | const char *name, void *value, | ~~~~~~^~~~~
vim +273 fs/overlayfs/overlayfs.h
c914c0e27eb084 Amir Goldstein 2022-04-04 268 c914c0e27eb084 Amir Goldstein 2022-04-04 269 static inline int ovl_setxattr(struct ovl_fs *ofs, struct dentry *dentry, 43d193f8440d67 Miklos Szeredi 2020-09-02 270 enum ovl_xattr ox, const void *value, 610afc0bd40882 Miklos Szeredi 2020-09-02 271 size_t size) e9be9d5e76e348 Miklos Szeredi 2014-10-24 272 { c914c0e27eb084 Amir Goldstein 2022-04-04 @273 return ovl_do_setxattr(ofs, dentry, ovl_xattr(ofs, ox), value, size, 0); e9be9d5e76e348 Miklos Szeredi 2014-10-24 274 } e9be9d5e76e348 Miklos Szeredi 2014-10-24 275
:::::: The code at line 273 was first introduced by commit :::::: c914c0e27eb0843b7cf3bec71d6f34d53a3a671e ovl: use wrappers to all vfs_*xattr() calls
:::::: TO: Amir Goldstein <amir73il@gmail.com> :::::: CC: Miklos Szeredi <mszeredi@redhat.com>
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |