Messages in this thread | | | Date | Tue, 5 Jul 2022 18:00:20 +0200 | Subject | Re: [PATCH v7 1/4] media: dt-bindings: ov5675: document YAML binding | From | Quentin Schulz <> |
| |
Hi all,
Any additional feedback to give on the series?
Thanks, Quentin
On 6/8/22 15:44, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > This patch adds documentation of device tree in YAML schema for the > OV5675 CMOS image sensor from Omnivision. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> > --- > > v4: > - added Reviewed-by, > > v3: > - removed clock-names, > - removed clock-frequency, > - added all-of of video-interface-devices schema, > - added clock frequency range in description, > - rephrased definition of supplies, > - fixed name of reset gpio, > - used schema ref for port and port->endpoint, > - removed mentions to driver, > - added HW data transfer speed limitation in comment for > link-frequencies, > - changed root additionalProperties to unevaluatedProperties to not > have to list all properties from video-interface-devices schema, such as > orientation or rotation, > - added maxItems to reset-gpios, > - updated example to use assigned-clocks and assigned-clock-rates > instead of clock-frequency and clock-names, > > v2: > - fixed incorrect id, > - fixed device tree example by adding missing dt-bindings headers, > - fixed device tree example by using vcc_1v2 for dvdd supply, as requested > in datasheet, > > .../bindings/media/i2c/ovti,ov5675.yaml | 123 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 124 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml > new file mode 100644 > index 000000000000..f0a48707bed7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml > @@ -0,0 +1,123 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2022 Theobroma Systems Design und Consulting GmbH > +%YAML 1.2 > +--- > +$id: https://urldefense.proofpoint.com/v2/url?u=http-3A__devicetree.org_schemas_media_i2c_ovti-2Cov5675.yaml-23&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=hkLsYZWMEhpLI6ShhGo0x3Jiuqy6R6W720Ntjy_xiWib19fmlU43ao0fGq1ALlC0&s=dJP3Z1NZNxGh-udGBCMYQKpHV17u1R0DloWk1smrUPE&e= > +$schema: https://urldefense.proofpoint.com/v2/url?u=http-3A__devicetree.org_meta-2Dschemas_core.yaml-23&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=hkLsYZWMEhpLI6ShhGo0x3Jiuqy6R6W720Ntjy_xiWib19fmlU43ao0fGq1ALlC0&s=hJpvHfydAEL-abkbxj-ZSKxgR5wrNKozJb-oj-TaIfc&e= > + > +title: Omnivision OV5675 CMOS Sensor > + > +maintainers: > + - Quentin Schulz <quentin.schulz@theobroma-systems.com> > + > +allOf: > + - $ref: /schemas/media/video-interface-devices.yaml# > + > +description: | > + The Omnivision OV5675 is a high performance, 1/5-inch, 5 megapixel, CMOS > + image sensor that delivers 2592x1944 at 30fps. It provides full-frame, > + sub-sampled, and windowed 10-bit MIPI images in various formats via the > + Serial Camera Control Bus (SCCB) interface. > + > + This chip is programmable through I2C and two-wire SCCB. The sensor output > + is available via CSI-2 serial data output (up to 2-lane). > + > +properties: > + compatible: > + const: ovti,ov5675 > + > + reg: > + maxItems: 1 > + > + clocks: > + description: > + System input clock (aka XVCLK). From 6 to 27 MHz. > + maxItems: 1 > + > + dovdd-supply: > + description: > + Digital I/O voltage supply, 1.8 volts. > + > + avdd-supply: > + description: > + Analog voltage supply, 2.8 volts. > + > + dvdd-supply: > + description: > + Digital core voltage supply, 1.2 volts. > + > + reset-gpios: > + description: > + The phandle and specifier for the GPIO that controls sensor reset. > + This corresponds to the hardware pin XSHUTDN which is physically > + active low. > + maxItems: 1 > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 2 > + > + # Supports max data transfer of 900 Mbps per lane > + link-frequencies: true > + > +required: > + - compatible > + - reg > + - clocks > + - dovdd-supply > + - avdd-supply > + - dvdd-supply > + - port > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/px30-cru.h> > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/pinctrl/rockchip.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ov5675: camera@36 { > + compatible = "ovti,ov5675"; > + reg = <0x36>; > + > + reset-gpios = <&gpio2 RK_PB1 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&cif_clkout_m0>; > + > + clocks = <&cru SCLK_CIF_OUT>; > + assigned-clocks = <&cru SCLK_CIF_OUT>; > + assigned-clock-rates = <19200000>; > + > + avdd-supply = <&vcc_1v8>; > + dvdd-supply = <&vcc_1v2>; > + dovdd-supply = <&vcc_2v8>; > + > + rotation = <90>; > + orientation = <0>; > + > + port { > + ucam_out: endpoint { > + remote-endpoint = <&mipi_in_ucam>; > + data-lanes = <1 2>; > + link-frequencies = /bits/ 64 <450000000>; > + }; > + }; > + }; > + }; > +... > + > diff --git a/MAINTAINERS b/MAINTAINERS > index a6d3bd9d2a8d..302983893831 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14703,6 +14703,7 @@ M: Shawn Tu <shawnx.tu@intel.com> > L: linux-media@vger.kernel.org > S: Maintained > T: git git://linuxtv.org/media_tree.git > +F: Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml > F: drivers/media/i2c/ov5675.c > > OMNIVISION OV5693 SENSOR DRIVER
| |