Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 5 Jul 2022 17:33:51 +0200 | Subject | Re: [PATCH v1 4/4] bus: hisi_lpc: Don't guard ACPI IDs with ACPI_PTR() |
| |
On Tue, Jul 5, 2022 at 5:27 PM John Garry <john.garry@huawei.com> wrote: > On 05/07/2022 16:15, Andy Shevchenko wrote:
...
> >>> The OF is not guarded, neither ACPI needs. > >> This doesn't read well. > > "The OF is not guarded, neither ACPI needs it." > > > > Better? Otherwise please propose how it can be amended here. > > How about "The OF ID table is not guarded, and the ACPI table does not > needs it either."?
FIne with me.
...
> > Strictly speaking, yes we need mod_devicetable.h. But of.h and acpi.h > > include it. > > acpi.h does not include it for !CONFIG_ACPI, which is the only one which > I had checked. But now I see that of.h always includes it, so what you > are doing is ok.
What a surprise. I was under the impression that acpi.h always includes it. Hmm... Probably we never had drivers that in Kconfig have something like "depends on ACPI || COMPILE_TEST (and at the same time have no explicit mod_devicetable.h inclusion nor implicit providers like of.h), which should immediately point to the issue.
-- With Best Regards, Andy Shevchenko
| |