Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 5 Jul 2022 17:23:06 +0200 | Subject | Re: [PATCH v1 1/4] bus: hisi_lpc: Don't dereference fwnode handle |
| |
On Tue, Jul 5, 2022 at 5:11 PM John Garry <john.garry@huawei.com> wrote: > On 05/07/2022 12:43, Andy Shevchenko wrote: > > Use dev_fwnode() and acpi_fwnode_handle() instead of dereferencing > > an fwnode handle directly. > > ...which is a better coding practice, right? If so, it would be nice to > mention it - well at least I think so.
Not only. In the case of fwnode it's a long story behind its corner case(s) where in the future we might switch from embedded structure to linked list, for example, in order to address those corner cases. Should I write a paragraph for that as well?
...
> Apart from above and nit, below:
See below my answer.
> Acked-by: John Garry <john.garry@huawei.com>
Thanks.
...
> > - sys_port = logic_pio_trans_hwaddr(&host->fwnode, res->start, len); > > + sys_port = logic_pio_trans_hwaddr(acpi_fwnode_handle(host), res->start, len); > > nit: currently the driver keeps to the old 80 character line limit. > While the rules may have been relaxed, I'd rather we still maintain it.
First of all, even before the 100 characters era the rule had two exceptions: 1) the string literals; 2) the readability over strictness of the 80 characters rule.
While I agree in general with you, in this case I think keeping strictness makes readability worse.
-- With Best Regards, Andy Shevchenko
| |