lkml.org 
[lkml]   [2022]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched/fair: fix boolreturn.cocci warning
On Tue,  5 Jul 2022 15:38:22 +0800
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:

> This was found by coccicheck:
>
> ./kernel/sched/fair.c:9988:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool.
>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

As your subject says "fix boolreturn.cocci warning". Can you please?

That is, this change has been presented 10 times before, and every time
it is nacked or ignored. The true fix is to fix boolreturn.cocci to not
warn about this in existing code.

Just in case it wasn't clear. NACK to this change.

-- Steve

\
 
 \ /
  Last update: 2022-07-05 16:33    [W:0.039 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site