lkml.org 
[lkml]   [2022]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 4/4] bus: hisi_lpc: Don't guard ACPI IDs with ACPI_PTR()
From
On 7/5/2022 1:43 PM, Andy Shevchenko wrote:
> The OF is not guarded neither ACPI needs. The IDs do not depend
> to the configuration. Hence drop ACPI_PTR() from the code and
> move ID table closer to its user.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>


> ---
> drivers/bus/hisi_lpc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index a6513a571d7b..74f4448bff9d 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -589,11 +589,6 @@ static int hisi_lpc_acpi_probe(struct device *hostdev)
>
> return ret;
> }
> -
> -static const struct acpi_device_id hisi_lpc_acpi_match[] = {
> - {"HISI0191"},
> - {}
> -};
> #else
> static int hisi_lpc_acpi_probe(struct device *dev)
> {
> @@ -688,11 +683,16 @@ static const struct of_device_id hisi_lpc_of_match[] = {
> {}
> };
>
> +static const struct acpi_device_id hisi_lpc_acpi_match[] = {
> + {"HISI0191"},
> + {}
> +};
> +
> static struct platform_driver hisi_lpc_driver = {
> .driver = {
> .name = DRV_NAME,
> .of_match_table = hisi_lpc_of_match,
> - .acpi_match_table = ACPI_PTR(hisi_lpc_acpi_match),
> + .acpi_match_table = hisi_lpc_acpi_match,
> },
> .probe = hisi_lpc_probe,
> .remove = hisi_lpc_remove,


\
 
 \ /
  Last update: 2022-07-05 16:24    [W:0.543 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site