[lkml]   [2022]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v7 3/5] gpio: gpiolib: Allow free() callback to be overridden
On Sun, Jul 3, 2022 at 9:43 PM Lad Prabhakar <> wrote:
> Allow free() callback to be overridden from irq_domain_ops for
> hierarchical chips.
> This allows drivers to free up resources which are allocated during
> child_to_parent_hwirq()/populate_parent_alloc_arg() callbacks.
> On Renesas RZ/G2L platform a bitmap is maintained for TINT slots, a slot
> is allocated in child_to_parent_hwirq() callback which is freed up in free
> callback hence this override.

Hmm... To me this sounds asymmetrical. We alloc something in another
callback, which is not what this free is for. Perhaps it should be an

free_populated_parent_arg() or alike?

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2022-07-04 18:16    [W:0.058 / U:2.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site