Messages in this thread |  | | Date | Mon, 4 Jul 2022 09:07:19 +0200 | Subject | Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support | From | Ahmad Fatoum <> |
| |
Hello Wei,
On 04.07.22 12:10, Wei Fang wrote: > + clock_ext_rmii: clock-ext-rmii { > + compatible = "fixed-clock"; > + clock-frequency = <50000000>; > + #clock-cells = <0>; > + clock-output-names = "ext_rmii_clk"; > + }; > + > + clock_ext_ts: clock-ext-ts { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-output-names = "ext_ts_clk"; > + };
How are these SoC-specific? They sound like they belong into board DT.
> + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>, > + <&pcc4 IMX8ULP_CLK_ENET>, > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>, > + <&clock_ext_rmii>; > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
I think the default should be the other way round, assume MAC to provide reference clock and allow override on board-level if PHY does it instead.
Cheers, Ahmad
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
|  |