lkml.org 
[lkml]   [2022]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] module: Use vzalloc() instead of vmalloc()/memset(0)
On Mon 2022-07-04 20:03 +0800, Yang Yingliang wrote:
> Use vzalloc() instead of vmalloc() and memset(0) to simpify the code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> kernel/module/main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index fed58d30725d..02b67abc448f 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -2138,7 +2138,7 @@ static int move_module(struct module *mod, struct load_info *info)
>
> #ifdef CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC
> /* Do the allocs. */
> - ptr = vmalloc(mod->data_layout.size);
> + ptr = vzalloc(mod->data_layout.size);
> /*
> * The pointer to this block is stored in the module structure
> * which is inside the block. Just mark it as not being a
> @@ -2151,7 +2151,6 @@ static int move_module(struct module *mod, struct load_info *info)
> return -ENOMEM;
> }
>
> - memset(ptr, 0, mod->data_layout.size);
> mod->data_layout.base = ptr;
> #endif
> /* Transfer each section which specifies SHF_ALLOC */
> --
> 2.25.1
>

Hi Yang,

Nice!

Reviewed-by: Aaron Tomlin <atomlin@redhat.com>


Kind regards,

--
Aaron Tomlin

\
 
 \ /
  Last update: 2022-07-04 16:47    [W:0.109 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site