lkml.org 
[lkml]   [2022]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/5] dt-bindings: interconnect: Update property for icc-rpm path tag
From
On 04/07/2022 11:30, Leo Yan wrote:
> To support path tag in icc-rpm driver, the "#interconnect-cells"
> property is updated as enumerate values: 1 or 2. Setting to 1 means
> it is compatible with old DT binding that interconnect path only
> contains node id; if set to 2 for "#interconnect-cells" property, then
> the second specifier is used as a tag (e.g. vote for which buckets).
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> .../devicetree/bindings/interconnect/qcom,rpm.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
> index 8a676fef8c1d..cdfe419e7339 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
> @@ -45,7 +45,12 @@ properties:
> - qcom,sdm660-snoc
>
> '#interconnect-cells':
> - const: 1
> + description: |
> + Number of interconnect specifier. Value: <1> is one cell in a
> + interconnect specifier for the interconnect node id, <2> requires
> + the interconnect node id and an extra path tag.
> + $ref: /schemas/types.yaml#/definitions/uint32

Ah, too fast. No ack. This ref is also pointless and not explained in
commit msg.

> + enum: [ 1, 2 ]
>
> clocks:
> minItems: 2


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-07-04 14:49    [W:0.072 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site