Messages in this thread | | | From | Jiri Olsa <> | Date | Mon, 4 Jul 2022 13:25:28 +0200 | Subject | Re: [PATCH] perf parse: Allow names to start with digits |
| |
On Mon, Jul 04, 2022 at 08:58:45AM +0900, Dominique Martinet wrote: > Jiri Olsa wrote on Sun, Jul 03, 2022 at 03:46:33PM +0200: > > > not sure if there'd be any other way of testing, there's nothing else in > > > 'perf list' that starts with a number. > > > > maybe we could do it same way we did for fake pmu events like below > > hmm, I'll have to defer to you on that honestly. > > It looks good to me though and I've tested your diff (test succeeds even > with 9pnet module unloaded). > > Just a note though, this makes test no longer checks the sys event > directories exist for all other tests in these arrays (test__events, > test__events_pmu and test__hybrid_events); if we have guarantees the > probes exist I believe at least a few should keep checking the format > path correctly. > It might be worth adding a check_format flag to test_event() and add a > new list that doesn't check formats just for 9p?
format provides only id which we don't check for tracepoints
> > If you're ok with that I can resend this as three patches: my original > patch, a patch with your diff and test_event() keeping current > behaviour, and a last patch adding that last flag and testing 9p without > format check. > > (and if you don't think it's worth checking probe existence same thing > but even simpler)
I have that patch split into 2 separated changes, I'll try to send it later today
jirka
| |