Messages in this thread | | | Date | Mon, 4 Jul 2022 15:49:55 +0530 | From | Manivannan Sadhasivam <> | Subject | Re: [PATCH v2] PCI: endpoint: reduce several globals to statics |
| |
On Thu, Jun 30, 2022 at 05:05:17PM -0400, Tom Rix wrote: > sparse reports > drivers/pci/endpoint/functions/pci-epf-vntb.c:956:10: warning: symbol 'pci_space' was not declared. Should it be static? > drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning: symbol 'pci_read' was not declared. Should it be static? > drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning: symbol 'pci_write' was not declared. Should it be static? > drivers/pci/endpoint/functions/pci-epf-vntb.c:989:16: warning: symbol 'vpci_ops' was not declared. Should it be static? > > These functions and variables are only used in pci-epf-vntb.c, so their storage > class specifiers should be static. > > Fixes: ff32fac00d97 ("NTB: EPF: support NTB transfer between PCI RC and EP connection") > Signed-off-by: Tom Rix <trix@redhat.com>
Commit subject should include "pci-epf-vntb" prefix. Otherwise it is not possible to guess which driver this patch touches (unless one reads commit description).
With that fixed,
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks, Mani
> --- > v2 : Change commit prefix > > --- > drivers/pci/endpoint/functions/pci-epf-vntb.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c > index ebf7e243eefa..6f0775b1fec3 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > @@ -953,7 +953,7 @@ static struct config_group *epf_ntb_add_cfs(struct pci_epf *epf, > > #define VPCI_BUS_NUM 0x10 > > -uint32_t pci_space[] = { > +static uint32_t pci_space[] = { > (VNTB_VID | (VNTB_PID << 16)), //DeviceID, Vendor ID > 0, // status, Command > 0xffffffff, // Class code, subclass, prog if, revision id > @@ -972,7 +972,7 @@ uint32_t pci_space[] = { > 0, //Max Lat, Min Gnt, interrupt pin, interrupt line > }; > > -int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val) > +static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val) > { > if (devfn == 0) { > memcpy(val, ((uint8_t *)pci_space) + where, size); > @@ -981,12 +981,12 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 * > return -1; > } > > -int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val) > +static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val) > { > return 0; > } > > -struct pci_ops vpci_ops = { > +static struct pci_ops vpci_ops = { > .read = pci_read, > .write = pci_write, > }; > -- > 2.27.0 >
-- மணிவண்ணன் சதாசிவம்
| |