Messages in this thread | | | Date | Mon, 4 Jul 2022 11:06:45 +0200 | Subject | Re: [PATCH 02/11] arm64: dts: mediatek: Introduce MT8195 Cherry platform's Tomato | From | AngeloGioacchino Del Regno <> |
| |
Il 04/07/22 11:05, Chen-Yu Tsai ha scritto: > On Mon, Jul 4, 2022 at 4:59 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> Il 04/07/22 06:17, Chen-Yu Tsai ha scritto: >>> On Sat, Jul 2, 2022 at 6:12 AM Nícolas F. R. A. Prado >>> <nfraprado@collabora.com> wrote: >>>> >>>> On Thu, Jun 30, 2022 at 05:33:07PM +0200, AngeloGioacchino Del Regno wrote: >>>>> Introduce the MT8195 Cherry Chromebook platform, including three >>>>> revisions of Cherry Tomato boards. >>>>> >>>>> This basic configuration allows to boot Linux on all board revisions >>>>> and get a serial console from a ramdisk. >>>>> >>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>>>> --- >>>>> arch/arm64/boot/dts/mediatek/Makefile | 3 +++ >>>>> .../dts/mediatek/mt8195-cherry-tomato-r1.dts | 11 ++++++++ >>>>> .../dts/mediatek/mt8195-cherry-tomato-r2.dts | 11 ++++++++ >>>>> .../dts/mediatek/mt8195-cherry-tomato-r3.dts | 12 +++++++++ >>>>> .../boot/dts/mediatek/mt8195-cherry.dtsi | 26 +++++++++++++++++++ >>>>> 5 files changed, 63 insertions(+) >>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts >>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts >>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts >>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi >>>> [..] >>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts >>>>> new file mode 100644 >>>>> index 000000000000..17e9e4d6f6ab >>>>> --- /dev/null >>>>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts >>>>> @@ -0,0 +1,11 @@ >>>>> +// SPDX-License-Identifier: (GPL-2.0 OR MIT) >>>>> +/* >>>>> + * Copyright (C) 2021 MediaTek Inc. >>>>> + */ >>>>> +/dts-v1/; >>>>> +#include "mt8195-cherry.dtsi" >>>>> + >>>>> +/ { >>>>> + model = "MediaTek Tomato (rev1) board"; >>>> >>>> Given that the compatible is "google," I believe we'll want to rename the model >>>> to "Google Tomato", much like was commented on the Asurada series [1], but >>>> better to have confirmation from someone from Google. Chen-Yu? :) >>> >>> I asked for clarification internally and it turns out we didn't get the >>> Asurada series quite right either. >>> >>> Google only owns the reference design, that is Asurada for MT8192 and >>> Cherry for MT8195. The vendor own the end product design that is based >>> off of Google's reference design. >>> >>> So for Tomato, the vendor is Acer. Note that "Tomato" and the other >>> codenames seen in ChromeOS are public codenames that Google uses. >>> >>> The compatible string will likely stay "google,XXX", since this is set >>> in firmware, and updating it after the product has shipped poses both >>> a significant hurdle and risk. >>> >> >> Yeah, makes sense. Should we call this "Acer Tomato (revX) board" then? >> ...if we do that, though, we need to know if the other revisions of Tomato >> are also from Acer, or we would be getting one right and all the others wrong. > > AFAIK each "device build" is its own project and gets its own codename, > otherwise it would get real confusing for us internally really fast.
All clear.
Thanks, Angelo
> > ChenYu > >> Cheers, >> Angelo >> >>> >>> Regards >>> ChenYu >>> >>>> Otherwise, >>>> >>>> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >>>> >>>> Thanks, >>>> Nícolas >>>> >>>> [1] https://lore.kernel.org/all/CAGXv+5Gv2pjPXynz6HCdgux+giPDC5qRk+KW1aFduVz82rM=+g@mail.gmail.com/ >>>> >>>>> + compatible = "google,tomato-rev1", "google,tomato", "mediatek,mt8195"; >>>>> +}; >>>> [..] >>>>> -- >>>>> 2.35.1 >>>>> >>
-- AngeloGioacchino Del Regno Software Engineer
Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK Registered in England & Wales, no. 5513718
| |