lkml.org 
[lkml]   [2022]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/11] dt-bindings: arm: mediatek: Add MT8195 Cherry Tomato Chromebooks
From
Il 02/07/22 00:04, Nícolas F. R. A. Prado ha scritto:
> On Thu, Jun 30, 2022 at 05:33:06PM +0200, AngeloGioacchino Del Regno wrote:
>> Document board compatibles for the MT8195 Cherry platform's
>> Tomato Chromebooks, at the time of writing composed of four
>> revisions (r0, r1, r2, r3-r4).
>
> Though r0 is not added in this series?
>
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> index dd6c6e8011f9..3e0afa17ed2e 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> @@ -144,6 +144,19 @@ properties:
>> - const: google,spherion-rev0
>> - const: google,spherion
>> - const: mediatek,mt8192
>
> Angelo, this patch is depending on the patch from the asurada-spherion series
> [1] to apply. Since this isn't the case for patch 2 as well, I assume this was
> a mistake. And it does seem better to keep them independent.

Yes, thanks for pointing that out - I forgot to advertise the dependency in the
cover letter.

Though, making this one independent from yours isn't really possible, as doing
that would ruin the ordering in mediatek.yaml.

I will advertise the dependency in v2.

Cheers,
Angelo

>
> [1] https://lore.kernel.org/all/20220629155956.1138955-2-nfraprado@collabora.com/
>
> Thanks,
> Nícolas
>
>> + - description: Google Tomato (Acer Chromebook Spin 513)
>> + items:
>> + - enum:
>> + - google,tomato-rev2
>> + - google,tomato-rev1
>> + - const: google,tomato
>> + - const: mediatek,mt8195
>> + - description: Google Tomato (rev3 - 4)
>> + items:
>> + - const: google,tomato-rev4
>> + - const: google,tomato-rev3
>> + - const: google,tomato
>> + - const: mediatek,mt8195
>> - items:
>> - enum:
>> - mediatek,mt8186-evb
>> --
>> 2.35.1
>>



\
 
 \ /
  Last update: 2022-07-04 10:58    [W:0.113 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site