lkml.org 
[lkml]   [2022]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support
> > +				clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>,
> > + <&pcc4 IMX8ULP_CLK_ENET>,
> > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>,
> > + <&clock_ext_rmii>;
> > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
>
> I think the default should be the other way round, assume MAC to provide reference
> clock and allow override on board-level if PHY does it instead.

I would make it the same as all the other instances of FEC in the
IMX7, IMX6, IMX5, IMX4, Vybrid etc

Andrew

\
 
 \ /
  Last update: 2022-07-04 10:15    [W:0.069 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site