lkml.org 
[lkml]   [2022]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/4] dt-bindings: usb: typec: add bindings for stm32g0 controller
From
On 01/07/2022 12:04, Fabrice Gasnier wrote:
>
> Then I no longer get this warning upon build. But the dtbs_check complains:
> ---
> connector: ports: 'port@0' is a required property
> From schema: ..
> Documentation/devicetree/bindings/connector/usb-connector.yaml
>
> So It looks like to me there's something missing to handle the single
> port case in usb-connector.yaml, when using the "ports".
>
> Maybe usb-connector could be updated to handle "port" (w/o unit-addr) ?

Not really, the dtc warning looks false-positive. Especially that you
need port@1 for USB 3.0 (super speed), unless you do not support it?

> I'm talking about:
> required:
> - port@0
>
> So, I came up with:
>
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -176,6 +176,9 @@ properties:
> port number as described below.
>
> properties:
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> +
> port@0:
> $ref: /schemas/graph.yaml#/properties/port
> description: High Speed (HS), present in all connectors.
> @@ -189,8 +192,11 @@ properties:
> description: Sideband Use (SBU), present in USB-C. This
> describes the
> alternate mode connection of which SBU is a part.
>
> - required:
> - - port@0
> + oneOf:
> + - required:
> + - port
> + - required:
> + - port@0
>
>
> Do you agree on this approach ? (I can add a pre-cursor patch to this
> series, to handle the single port case)



Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-07-04 09:56    [W:1.953 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site