lkml.org 
[lkml]   [2022]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v15 05/16] drm/mediatek: dpi: Add support for quantization range
    From
    Date
    Hi, Bo-Chen:

    On Fri, 2022-07-01 at 11:58 +0800, Bo-Chen Chen wrote:
    > For RGB colorimetry, CTA-861 support both limited and full range data
    > when receiving video with RGB color space.
    > We use drm_default_rgb_quant_range() to determine the correct
    > setting.

    Applied to mediatek-drm-next [1], thanks.

    [1]
    https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

    Regards,
    CK

    >
    > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
    > Reviewed-by: CK Hu <ck.hu@mediatek.com>
    > Reviewed-by: AngeloGioacchino Del Regno <
    > angelogioacchino.delregno@collabora.com>
    > ---
    > drivers/gpu/drm/mediatek/mtk_dpi.c | 34 ++++++++++++++++++--------
    > ----
    > 1 file changed, 21 insertions(+), 13 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
    > b/drivers/gpu/drm/mediatek/mtk_dpi.c
    > index 3473ee18ad97..0855bbdfe4e1 100644
    > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
    > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
    > @@ -238,16 +238,30 @@ static void mtk_dpi_config_fb_size(struct
    > mtk_dpi *dpi, u32 width, u32 height)
    > mtk_dpi_mask(dpi, DPI_SIZE, height << VSIZE, VSIZE_MASK);
    > }
    >
    > -static void mtk_dpi_config_channel_limit(struct mtk_dpi *dpi,
    > - struct mtk_dpi_yc_limit
    > *limit)
    > +static void mtk_dpi_config_channel_limit(struct mtk_dpi *dpi)
    > {
    > - mtk_dpi_mask(dpi, DPI_Y_LIMIT, limit->y_bottom << Y_LIMINT_BOT,
    > + struct mtk_dpi_yc_limit limit;
    > +
    > + if (drm_default_rgb_quant_range(&dpi->mode) ==
    > + HDMI_QUANTIZATION_RANGE_LIMITED) {
    > + limit.y_bottom = 0x10;
    > + limit.y_top = 0xfe0;
    > + limit.c_bottom = 0x10;
    > + limit.c_top = 0xfe0;
    > + } else {
    > + limit.y_bottom = 0;
    > + limit.y_top = 0xfff;
    > + limit.c_bottom = 0;
    > + limit.c_top = 0xfff;
    > + }
    > +
    > + mtk_dpi_mask(dpi, DPI_Y_LIMIT, limit.y_bottom << Y_LIMINT_BOT,
    > Y_LIMINT_BOT_MASK);
    > - mtk_dpi_mask(dpi, DPI_Y_LIMIT, limit->y_top << Y_LIMINT_TOP,
    > + mtk_dpi_mask(dpi, DPI_Y_LIMIT, limit.y_top << Y_LIMINT_TOP,
    > Y_LIMINT_TOP_MASK);
    > - mtk_dpi_mask(dpi, DPI_C_LIMIT, limit->c_bottom << C_LIMIT_BOT,
    > + mtk_dpi_mask(dpi, DPI_C_LIMIT, limit.c_bottom << C_LIMIT_BOT,
    > C_LIMIT_BOT_MASK);
    > - mtk_dpi_mask(dpi, DPI_C_LIMIT, limit->c_top << C_LIMIT_TOP,
    > + mtk_dpi_mask(dpi, DPI_C_LIMIT, limit.c_top << C_LIMIT_TOP,
    > C_LIMIT_TOP_MASK);
    > }
    >
    > @@ -439,7 +453,6 @@ static int mtk_dpi_power_on(struct mtk_dpi *dpi)
    > static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
    > struct drm_display_mode *mode)
    > {
    > - struct mtk_dpi_yc_limit limit;
    > struct mtk_dpi_polarities dpi_pol;
    > struct mtk_dpi_sync_param hsync;
    > struct mtk_dpi_sync_param vsync_lodd = { 0 };
    > @@ -474,11 +487,6 @@ static int mtk_dpi_set_display_mode(struct
    > mtk_dpi *dpi,
    > dev_dbg(dpi->dev, "Got PLL %lu Hz, pixel clock %lu Hz\n",
    > pll_rate, vm.pixelclock);
    >
    > - limit.c_bottom = 0x0010;
    > - limit.c_top = 0x0FE0;
    > - limit.y_bottom = 0x0010;
    > - limit.y_top = 0x0FE0;
    > -
    > dpi_pol.ck_pol = MTK_DPI_POLARITY_FALLING;
    > dpi_pol.de_pol = MTK_DPI_POLARITY_RISING;
    > dpi_pol.hsync_pol = vm.flags & DISPLAY_FLAGS_HSYNC_HIGH ?
    > @@ -526,7 +534,7 @@ static int mtk_dpi_set_display_mode(struct
    > mtk_dpi *dpi,
    > else
    > mtk_dpi_config_fb_size(dpi, vm.hactive, vm.vactive);
    >
    > - mtk_dpi_config_channel_limit(dpi, &limit);
    > + mtk_dpi_config_channel_limit(dpi);
    > mtk_dpi_config_bit_num(dpi, dpi->bit_num);
    > mtk_dpi_config_channel_swap(dpi, dpi->channel_swap);
    > mtk_dpi_config_yc_map(dpi, dpi->yc_map);

    \
     
     \ /
      Last update: 2022-07-05 05:51    [W:4.153 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site