Messages in this thread | | | From | Ian Rogers <> | Date | Mon, 4 Jul 2022 14:39:05 -0700 | Subject | Re: [PATCH] perf parse: Allow names to start with digits |
| |
On Sat, Jun 11, 2022 at 11:16 PM Dominique Martinet <asmadeus@codewreck.org> wrote: > > Tracepoints can start with digits, although we don't have many of these: > > $ rg -g '*.h' '\bTRACE_EVENT\([0-9]' > net/mac802154/trace.h > 53:TRACE_EVENT(802154_drv_return_int, > ... > > net/ieee802154/trace.h > 66:TRACE_EVENT(802154_rdev_add_virtual_intf, > ... > > include/trace/events/9p.h > 124:TRACE_EVENT(9p_client_req, > ... > > Just allow names to start with digits too so e.g. perf probe -e '9p:*' > works > > Signed-off-by: Dominique Martinet <asmadeus@codewreck.org> > --- > tools/perf/util/parse-events.l | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index 5b6e4b5249cf..4133d6950d29 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -211,7 +211,7 @@ bpf_source [^,{}]+\.c[a-zA-Z0-9._]* > num_dec [0-9]+ > num_hex 0x[a-fA-F0-9]+ > num_raw_hex [a-fA-F0-9]+ > -name [a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]!]* > +name [a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]!]*
Perhaps this would be cleaner as: name [a-zA-Z0-9_*?\[\]!]+ except that would allow a name to start with an exclamation. Would that be an issue?
Thanks, Ian
> name_tag [\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\'] > name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?.:]* > drv_cfg_term [a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)? > -- > 2.36.1 >
| |