lkml.org 
[lkml]   [2022]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-stable-rc:linux-5.15.y 6874/8723] arch/arm/lib/xor-neon.c:30:2: warning: This code requires at least version 4.6 of GCC
On Sun, Jul 31, 2022 at 01:15:59AM +0200, Jason A. Donenfeld wrote:
> On Sat, Jul 30, 2022 at 04:33:28PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Jul 25, 2022 at 04:35:38PM +0200, Arnd Bergmann wrote:
> > > On Mon, Jul 25, 2022 at 2:55 PM Arnd Bergmann <arnd@kernel.org> wrote:
> > >
> > > > The other easy workaround would be to just turn off the xor-neon code
> > > > when building with clang, e.g. using this Makefile hack:
> > > >
> > > > diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile
> > > > index 6d2ba454f25b..8e4fe6421dd2 100644
> > > > --- a/arch/arm/lib/Makefile
> > > > +++ b/arch/arm/lib/Makefile
> > > > @@ -43,8 +43,10 @@ endif
> > > > $(obj)/csumpartialcopy.o: $(obj)/csumpartialcopygeneric.S
> > > > $(obj)/csumpartialcopyuser.o: $(obj)/csumpartialcopygeneric.S
> > > >
> > > > +ifdef CONFIG_CC_IS_CLANG
> > > > ifeq ($(CONFIG_KERNEL_MODE_NEON),y)
> > > > NEON_FLAGS := -march=armv7-a -mfloat-abi=softfp -mfpu=neon
> > > > CFLAGS_xor-neon.o += $(NEON_FLAGS)
> > > > obj-$(CONFIG_XOR_BLOCKS) += xor-neon.o
> > > > endif
> > > > +endif
> > >
> > > Nevermind, this does not actually work. Just turning off the warning
> > > is probably best then, as actually disabling this code would still
> > > be invasive not do much beyond saving a little bit of kernel .text size.
> >
> > Ok, if it triggers again, and I get annoyed, I'll write a patch,
> > otherwise I'll just leave it alone unless someone else wants to send it
> > to me...
>
> The patch is trivial, if your idea is just to remove the #warning,
> right? Might as well just do it now and get it over with.

Fine, I was being lazy :)

Now sent out:
https://lore.kernel.org/all/20220731100551.3679874-1-gregkh@linuxfoundation.org/

\
 
 \ /
  Last update: 2022-07-31 12:14    [W:0.222 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site