lkml.org 
[lkml]   [2022]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 05/13] regulator: qcom_spmi: Add support for new regulator types
Hi Iskren,

I love your patch! Yet something to improve:

[auto build test ERROR on broonie-regulator/for-next]
[also build test ERROR on next-20220728]
[cannot apply to krzk-dt/for-next linus/master v5.19]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Iskren-Chernev/PM6125-regulator-support/20220801-064059
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: arm64-buildonly-randconfig-r005-20220731 (https://download.01.org/0day-ci/archive/20220801/202208011110.Bms4zAP4-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 52cd00cabf479aa7eb6dbb063b7ba41ea57bce9e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/3758c84ef9cec75fc09a3463506782d3179fe480
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Iskren-Chernev/PM6125-regulator-support/20220801-064059
git checkout 3758c84ef9cec75fc09a3463506782d3179fe480
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/regulator/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/regulator/qcom_spmi-regulator.c:1565:15: error: incompatible function pointer types initializing 'unsigned int (*)(struct regulator_dev *)' with an expression of type 'int (struct regulator_dev *, unsigned int)' [-Werror,-Wincompatible-function-pointer-types]
.get_mode = spmi_regulator_ftsmps3_get_mode,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


vim +1565 drivers/regulator/qcom_spmi-regulator.c

1554
1555 static const struct regulator_ops spmi_ftsmps3_ops = {
1556 .enable = regulator_enable_regmap,
1557 .disable = regulator_disable_regmap,
1558 .is_enabled = regulator_is_enabled_regmap,
1559 .set_voltage_sel = spmi_regulator_ftsmps426_set_voltage,
1560 .set_voltage_time_sel = spmi_regulator_set_voltage_time_sel,
1561 .get_voltage_sel = spmi_regulator_ftsmps426_get_voltage,
1562 .map_voltage = spmi_regulator_single_map_voltage,
1563 .list_voltage = spmi_regulator_common_list_voltage,
1564 .set_mode = spmi_regulator_ftsmps3_set_mode,
> 1565 .get_mode = spmi_regulator_ftsmps3_get_mode,
1566 .set_load = spmi_regulator_common_set_load,
1567 .set_pull_down = spmi_regulator_common_set_pull_down,
1568 };
1569

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-08-01 05:55    [W:0.062 / U:1.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site