Messages in this thread | | | Subject | RE:(2) [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name | From | Jinyoung CHOI <> | Date | Mon, 01 Aug 2022 12:45:38 +0900 |
| |
>On 7/28/22 21:54, Jinyoung CHOI wrote: >> -static inline void ufshcd_wb_config(struct ufs_hba *hba) >> +static void ufshcd_wb_set_default_flags(struct ufs_hba *hba) > >It is not clear to me why the new name is considered an improvement? The >old name looks better to me. If you want to rename this function anyway, >how about ufshcd_configure_wb()? > >Thanks, > >Bart.
It is desirable to express it as configure because it sets several values. I will change it. Thank you for your opinion.
Kind Regards, Jinyoung.
| |