Messages in this thread | | | Date | Sun, 31 Jul 2022 22:24:34 +0200 | Subject | Re: [PATCH v2 02/10] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc | From | Christophe JAILLET <> |
| |
Le 31/07/2022 à 22:12, Andy Shevchenko a écrit : > The core part is misleading since its only purpose to serve Crystal Cove PMIC, > although for couple of different platforms. Merge core part into crc one. > > Advantages among others are: > - speed up a compilation and build > - decreasing the code base > - reducing noise in the namespace by making some data static and const > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Tested-by: Hans de Goede <hdegoede@redhat.com> > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > --- > v2: added tags and rebased on top of new patch 1 > > drivers/mfd/Makefile | 3 +- > drivers/mfd/intel_soc_pmic_core.h | 25 ----- > drivers/mfd/intel_soc_pmic_crc.c | 163 ++++++++++++++++++++++++++++-- > 3 files changed, 158 insertions(+), 33 deletions(-) > delete mode 100644 drivers/mfd/intel_soc_pmic_core.h >
Hi,
in v1, there was a: drivers/mfd/intel_soc_pmic_core.c | 160 ----------------------------- delete mode 100644 drivers/mfd/intel_soc_pmic_core.c
Is it expected not to have it in v2?
CJ
| |