Messages in this thread | | | From | Martin Blumenstingl <> | Date | Sun, 31 Jul 2022 22:14:19 +0200 | Subject | Re: [PATCH RFC v1] spi: realtek-rtl: Fix clearing some register bits |
| |
Hi Birger,
On Fri, Jul 29, 2022 at 10:20 AM Birger Koblitz <mail@birger-koblitz.de> wrote: > > Hi Martin, > > On 7/28/22 17:27, Martin Blumenstingl wrote: > > Your patch actually addresses an issue which I have seen with RTL_SPI_SFCSR_CS. > > Since you seem to have boards with these Realtek SoCs: could you > > please clean up your patch and upstream it (splitting into smaller > > patches if/where needed)? That would be a win-win: upstream gains > > improved SPI support and I won't be confused the next time I look at > > the spi-realtek-rtl driver. > > Thanks for suggesting this! I will send a patch-set later today along > these lines, I first need to set up a linux dev environment as the > development so far was within OpenWRT. There's not a single right or wrong. The fewer patches a target has in OpenWrt the easier it gets in my experience. The most simple approach in my opinion is to make OpenWrt use an external kernel tree (using CONFIG_EXTERNAL_KERNEL_TREE).
Best regards, Martin
| |