Messages in this thread | | | Date | Sat, 30 Jul 2022 12:15:17 +0300 | Subject | Re: [RFC PATCH net-next] dt-bindings: net: dsa: mediatek,mt7530: completely rework binding | From | Arınç ÜNAL <> |
| |
On 28.07.2022 19:14, Daniel Golle wrote: > Hi, > > please see a minor comment inline below: > > On Tue, Jul 26, 2022 at 03:24:06PM +0300, Arınç ÜNAL wrote: >> [...] >> - CPU-Ports need a phy-mode property: >> - Allowed values on mt7530 and mt7621: >> - - "rgmii" >> - - "trgmii" >> - On mt7531: >> - - "1000base-x" >> - - "2500base-x" >> - - "rgmii" >> - - "sgmii" >> + There are two versions of MT7530. MT7621AT, MT7621DAT, MT7621ST and MT7623AI > > There are two version of MT7530 **supported by this driver**..... > (MT7620 also contains MT7530, switch registers are directly mapped into > SoC's memory map rather than using MDIO like on MT7621 and standalone > variants, and it got FastEthernet PHYs for Port 0-4)
Thanks Daniel. To be precise, this is the case for MT7620AN, MT7620DA, MT7620DAN, MT7620NN, MT7628AN, MT7628DAN, MT7628DBN, MT7628KN, MT7628NN, MT7688AN and MT7688KN SoCs as all include a 5p FE switch according to Russia hosted WikiDevi.
I'll update the description accordingly.
Arınç
| |