lkml.org 
[lkml]   [2022]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] stmmac: intel: Add a missing clk_disable_unprepare() call in intel_eth_pci_remove()
    Hi Christophe,

    Thank you for the patch! Yet something to improve:

    [auto build test ERROR on linus/master]
    [also build test ERROR on v5.19-rc8 next-20220728]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Christophe-JAILLET/stmmac-intel-Add-a-missing-clk_disable_unprepare-call-in-intel_eth_pci_remove/20220731-022139
    base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 620725263f4222b3c94d4ee19846835feec0ad69
    config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220731/202207310545.hHU5SagS-lkp@intel.com/config)
    compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 52cd00cabf479aa7eb6dbb063b7ba41ea57bce9e)
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/intel-lab-lkp/linux/commit/2d1d09034cc62ee19f799b92bb67640ba86ca557
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Christophe-JAILLET/stmmac-intel-Add-a-missing-clk_disable_unprepare-call-in-intel_eth_pci_remove/20220731-022139
    git checkout 2d1d09034cc62ee19f799b92bb67640ba86ca557
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

    If you fix the issue, kindly add following tag where applicable
    Reported-by: kernel test robot <lkp@intel.com>

    All errors (new ones prefixed by >>):

    >> drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c:1107:24: error: use of undeclared identifier 'plat'
    clk_disable_unprepare(plat->stmmac_clk);
    ^
    1 error generated.


    vim +/plat +1107 drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

    1092
    1093 /**
    1094 * intel_eth_pci_remove
    1095 *
    1096 * @pdev: pci device pointer
    1097 * Description: this function calls the main to free the net resources
    1098 * and releases the PCI resources.
    1099 */
    1100 static void intel_eth_pci_remove(struct pci_dev *pdev)
    1101 {
    1102 struct net_device *ndev = dev_get_drvdata(&pdev->dev);
    1103 struct stmmac_priv *priv = netdev_priv(ndev);
    1104
    1105 stmmac_dvr_remove(&pdev->dev);
    1106
    > 1107 clk_disable_unprepare(plat->stmmac_clk);
    1108 clk_unregister_fixed_rate(priv->plat->stmmac_clk);
    1109
    1110 pcim_iounmap_regions(pdev, BIT(0));
    1111 }
    1112

    --
    0-DAY CI Kernel Test Service
    https://01.org/lkp

    \
     
     \ /
      Last update: 2022-07-30 23:51    [W:2.458 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site