Messages in this thread | | | Date | Mon, 4 Jul 2022 11:57:28 +0800 | Subject | Re: [PATCH 12/14] loongarch: drop definition of PGD_ORDER | From | WANG Xuerui <> |
| |
On 2022/7/4 04:50, Matthew Wilcox wrote: > On Sun, Jul 03, 2022 at 05:12:01PM +0300, Mike Rapoport wrote: >> +++ b/arch/loongarch/kernel/asm-offsets.c >> @@ -190,7 +190,6 @@ void output_mm_defines(void) >> #endif >> DEFINE(_PTE_T_LOG2, PTE_T_LOG2); >> BLANK(); >> - DEFINE(_PGD_ORDER, PGD_ORDER); >> BLANK(); >> DEFINE(_PMD_SHIFT, PMD_SHIFT); >> DEFINE(_PGDIR_SHIFT, PGDIR_SHIFT); > Should probably also drop one of these BLANK() lines too? > Agreed; IMO the blank lines can and should be removed because the surrounding lines are also mm definitions.
| |