Messages in this thread | | | From | Brad Larson <> | Date | Sun, 3 Jul 2022 15:06:07 -0700 | Subject | Re: [PATCH v5 15/15] reset: elbasr: Add AMD Pensando Elba SR Reset Controller |
| |
Hi Andy,
On Tue, Jun 14, 2022 at 4:47 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Mon, Jun 13, 2022 at 9:57 PM Brad Larson <brad@pensando.io> wrote: > > > > From: Brad Larson <blarson@amd.com> > > > > This patch adds the reset controller functionality for the > > AMD Pensando Elba System Resource Chip. > > ... > > > +#include <linux/mfd/pensando-elbasr.h> > > +#include <linux/platform_device.h> > > +#include <linux/reset-controller.h> > > +#include <linux/regmap.h> > > +#include <linux/err.h> > > > +#include <linux/of.h> > > There is no user of this header. But there are missed ones, such as > mod_devicetable.h. > > Keep them ordered to easily find such issues.
Removed of.h and added mod_devicetable.h.
> ... > > + ret = devm_reset_controller_register(&pdev->dev, &elbar->rcdev); > > + > > + return ret; > > It is simply `return devm_...(...);`. Looking through your patches I > can tell that you may easily drop LoCs by 10%. Please do so in the > next version.
Changed to return devm...(...)
> ... > > > +static const struct of_device_id elba_reset_dt_match[] = { > > + { .compatible = "amd,pensando-elbasr-reset", }, > > + { /* sentinel */ }, > > No comma.
Removed comma
Regards, Brad
| |