Messages in this thread |  | | From | Christophe Leroy <> | Subject | Re: [PATCH v11 09/14] module: Move kallsyms support into a separate file | Date | Sun, 3 Jul 2022 17:58:15 +0000 |
| |
Le 03/07/2022 à 16:13, Steven Rostedt a écrit : > On Sun, 3 Jul 2022 14:57:08 +0100 > Aaron Tomlin <atomlin@redhat.com> wrote: > >> Hi Steve, >> >> I completely agree and noted. >> >>> You even stated "no functional change" which was a lie. Converting >>> strlcpy() to strscpy() *is* a functional change! >> >> Understood. > > Sorry about being harsh. It's something that was engrained in me when > doing kernel development, and something I found useful for all software > development. > > Honestly, the hardest thing about kernel development is the review > process. The easier we can make reviewing, the better the code will be. >
I'm probably the one who misleaded Aaron.
When I started submitting Kernel patches years ago, I was given those guidelines: - Always submit checkpatch clean patches. - Try to never modify the same line of code twice in a series.
Which implied to always fix codying Style while changing or moving code.
Christophe
|  |