Messages in this thread |  | | From | Andy Shevchenko <> | Date | Sun, 3 Jul 2022 16:14:07 +0200 | Subject | Re: [PATCH 2/3] gpio: regmap: Support combined GPIO and pin control drivers |
| |
On Sun, Jul 3, 2022 at 1:11 PM Aidan MacDonald <aidanmacdonald.0x0@gmail.com> wrote: > > Allow gpio-regmap to be used for the GPIO portion of a combined > pin control and GPIO driver by setting the has_pinctrl flag. This > flag will cause GPIO direction set ops to be implemented as calls > to pinctrl_gpio_direction_input/output() instead of updating the > direction set registers directly. > > Note that reg_dir_out/in_base is still required for implementing > the GPIO chip's ->get_direction() callback.
...
> + /* > + * we need a direction register for implementing ->get_direction > + * even if ->direction_input/output is handled by pin control > + */
/* * Multi-line comments go with this format * or style. Pay attention to the capitalization * and English grammar, e.g. period at the end of sentence(s). */
...
> + if (config->has_pinctrl && !(config->reg_dir_in_base || > + config->reg_dir_out_base))
Can you re-indent this either to be one line or put the second part of the conditional onto the second line?
And why not use && everywhere?
> + return ERR_PTR(-EINVAL);
-- With Best Regards, Andy Shevchenko
|  |