lkml.org 
[lkml]   [2022]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 12/12] regmap-irq: Deprecate the not_fixed_stride flag
    Date
    This flag is a bit of a hack and the same thing can be accomplished
    using a custom ->get_irq_reg() callback. Add a warning to catch any
    use of the flag.

    Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
    ---
    drivers/base/regmap/regmap-irq.c | 2 ++
    include/linux/regmap.h | 6 ++++--
    2 files changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
    index ec658755dd1b..4ef9488d05cd 100644
    --- a/drivers/base/regmap/regmap-irq.c
    +++ b/drivers/base/regmap/regmap-irq.c
    @@ -739,6 +739,8 @@ int regmap_add_irq_chip_fwnode(struct fwnode_handle *fwnode,
    }

    if (chip->not_fixed_stride) {
    + dev_warn(map->dev, "not_fixed_stride is deprecated; use ->get_irq_reg() instead");
    +
    for (i = 0; i < chip->num_regs; i++)
    if (chip->sub_reg_offsets[i].num_regs != 1)
    return -EINVAL;
    diff --git a/include/linux/regmap.h b/include/linux/regmap.h
    index ae5f1f7d4b5a..84ab1c32271f 100644
    --- a/include/linux/regmap.h
    +++ b/include/linux/regmap.h
    @@ -1493,8 +1493,10 @@ struct regmap_irq_chip_data;
    * registers before unmasking interrupts to clear any bits
    * set when they were masked.
    * @not_fixed_stride: Used when chip peripherals are not laid out with fixed
    - * stride. Must be used with sub_reg_offsets containing the
    - * offsets to each peripheral.
    + * stride. Must be used with sub_reg_offsets containing the
    + * offsets to each peripheral. Deprecated; the same thing
    + * can be accomplished with a @get_irq_reg callback, without
    + * the need for a @sub_reg_offsets table.
    * @status_invert: Inverted status register: cleared bits are active interrupts.
    * @runtime_pm: Hold a runtime PM lock on the device when accessing it.
    *
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-07-03 13:22    [W:5.496 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site