Messages in this thread | | | Date | Fri, 29 Jul 2022 13:16:33 -0700 | Subject | Re: [PATCH v5 1/6] scsi: ufs: wb: Change wb_enabled condition test | From | Bart Van Assche <> |
| |
On 7/28/22 21:52, Jinyoung CHOI wrote: > Changed to improve readability. > As implemented in ufshcd_wb_togle_flush(), the conditional test is > modified in the same way. > > Reviewed-by: Avri Altman <avri.altman@wdc.com> > Reviewed-by: Bean Huo <beanhuo@micron.com> > Signed-off-by: Jinyoung Choi <j-young.choi@samsung.com> > --- > drivers/ufs/core/ufshcd.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index 8f11f118c30e..bbf12aa6a5ae 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -5730,10 +5730,8 @@ int ufshcd_wb_toggle(struct ufs_hba *hba, bool enable) > { > int ret; > > - if (!ufshcd_is_wb_allowed(hba)) > - return 0; > - > - if (!(enable ^ hba->dev_info.wb_enabled)) > + if (!ufshcd_is_wb_allowed(hba) || > + hba->dev_info.wb_enabled == enable) > return 0; > > ret = __ufshcd_wb_toggle(hba, enable, QUERY_FLAG_IDN_WB_EN);
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |