lkml.org 
[lkml]   [2022]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 31/35] drm/sun4i: tv: Add missing reset assertion
    Date
    The reset line is deasserted at bind, and asserted if we ever encounter an
    error there. However, it's never deasserted in unbind which will lead to a
    resource unbalance.

    Signed-off-by: Maxime Ripard <maxime@cerno.tech>

    diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
    index ad6a3739bfa9..74ff5ad6a8b9 100644
    --- a/drivers/gpu/drm/sun4i/sun4i_tv.c
    +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c
    @@ -605,6 +605,7 @@ static void sun4i_tv_unbind(struct device *dev, struct device *master,
    drm_connector_cleanup(&tv->connector);
    drm_encoder_cleanup(&tv->encoder);
    clk_disable_unprepare(tv->clk);
    + reset_control_assert(tv->reset);
    }

    static const struct component_ops sun4i_tv_ops = {
    --
    b4 0.10.0-dev-49460

    \
     
     \ /
      Last update: 2022-07-29 18:38    [W:2.093 / U:2.912 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site