lkml.org 
[lkml]   [2022]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net 2/2] net: ionic: fix error check for vlan flags in ionic_set_nic_features()
From
On 7/29/22 3:17 AM, Guangbin Huang wrote:
> From: Jian Shen <shenjian15@huawei.com>
>
> The prototype of input features of ionic_set_nic_features() is
> netdev_features_t, but the vlan_flags is using the private
> definition of ionic drivers. It should use the variable
> ctx.cmd.lif_setattr.features, rather than features to check
> the vlan flags. So fixes it.
>
> Fixes: beead698b173 ("ionic: Add the basic NDO callbacks for netdev support")
>
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>

Good catch - thanks!

Acked-by: Shannon Nelson <snelson@pensando.io>


> ---
> drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index f3568901eb91..1443f788ee37 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -1437,7 +1437,7 @@ static int ionic_set_nic_features(struct ionic_lif *lif,
> if ((old_hw_features ^ lif->hw_features) & IONIC_ETH_HW_RX_HASH)
> ionic_lif_rss_config(lif, lif->rss_types, NULL, NULL);
>
> - if ((vlan_flags & features) &&
> + if ((vlan_flags & le64_to_cpu(ctx.cmd.lif_setattr.features)) &&
> !(vlan_flags & le64_to_cpu(ctx.comp.lif_setattr.features)))
> dev_info_once(lif->ionic->dev, "NIC is not supporting vlan offload, likely in SmartNIC mode\n");
>

\
 
 \ /
  Last update: 2022-07-29 18:33    [W:0.060 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site