Messages in this thread | | | From | Ian Rogers <> | Date | Fri, 29 Jul 2022 07:39:14 -0700 | Subject | Re: [PATCH v2] perf parse-events: Break out tracepoint and printing. |
| |
On Fri, Jul 29, 2022 at 4:44 AM Jiri Olsa <olsajiri@gmail.com> wrote: > > On Thu, Jul 07, 2022 at 12:12:09PM -0700, Ian Rogers wrote: > > Move print_*_events functions out of parse-events.c into a new > > print-events.c. Move tracepoint code into tracepoint.c or > > trace-event-info.c (sole user). This reduces the dependencies of > > it seems like it'd be better to have those changes in separated > patches, at least for review
Agreed. I'll follow up with a v3.
Thanks, Ian
> jirka > > > parse-events.c and makes it more amenable to being a library in the > > future. > > Remove some unnecessary definitions from parse-events.h. Fix a > > checkpatch.pl warning on using unsigned rather than unsigned int. > > Fix some line length warnings too. > > > > v2. Rebase in particular after hybrid PMU changes. > > > > Signed-off-by: Ian Rogers <irogers@google.com> > > SNIP
| |