lkml.org 
[lkml]   [2022]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] bpf/verifier: fix control flow issues in __reg64_bound_u32()
Date
From: Zeng Jingxiang <linuszeng@tencent.com>

This greater-than-or-equal-to-zero comparison of an unsigned value
is always true. "a >= U32_MIN".
1632 return a >= U32_MIN && a <= U32_MAX;

Fixes: b9979db83401 ("bpf: Fix propagation of bounds from 64-bit min/max into 32-bit and var_off.")
Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
---
kernel/bpf/verifier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 0efbac0fd126..dd67108fb1d7 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -1629,7 +1629,7 @@ static bool __reg64_bound_s32(s64 a)

static bool __reg64_bound_u32(u64 a)
{
- return a >= U32_MIN && a <= U32_MAX;
+ return a <= U32_MAX;
}

static void __reg_combine_64_into_32(struct bpf_reg_state *reg)
--
2.27.0
\
 
 \ /
  Last update: 2022-07-29 07:51    [W:1.498 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site