Messages in this thread | | | Date | Fri, 29 Jul 2022 06:10:38 -0700 | From | Jerry Snitselaar <> | Subject | Re: [PATCH] iommu/amd: Fix compile warning in init code |
| |
On Fri, Jul 29, 2022 at 12:04:32PM +0200, Joerg Roedel wrote: > From: Joerg Roedel <jroedel@suse.de> > > A recent commit introduced these compile warnings: > > CC drivers/iommu/amd/init.o > drivers/iommu/amd/init.c:938:12: error: ‘iommu_init_ga_log’ defined but not used [-Werror=unused-function] > 938 | static int iommu_init_ga_log(struct amd_iommu *iommu) > | ^~~~~~~~~~~~~~~~~ > drivers/iommu/amd/init.c:902:12: error: ‘iommu_ga_log_enable’ defined but not used [-Werror=unused-function] > 902 | static int iommu_ga_log_enable(struct amd_iommu *iommu) > | ^~~~~~~~~~~~~~~~~~~ > > The warnings appear because both functions are defined when IRQ > remapping is not enabled, but only used when IRQ remapping is enabled. > > Fix it by only defining the functions when IRQ remapping is enabled. > > Fixes: c5e1a1eb9279 ("iommu/amd: Simplify and Consolidate Virtual APIC (AVIC) Enablement") > Signed-off-by: Joerg Roedel <jroedel@suse.de>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
| |