Messages in this thread | | | Date | Fri, 29 Jul 2022 15:10:25 +0300 | Subject | Re: [PATCH 1/3] ARM: dts: qcom: msm8960: add reference to sleep_clk | From | Dmitry Baryshkov <> |
| |
On 29/07/2022 15:01, Konrad Dybcio wrote: > > > On 29.07.2022 13:33, Dmitry Baryshkov wrote: >> On 28/07/2022 14:51, Krzysztof Kozlowski wrote: >>> On 28/07/2022 13:16, Shinjo Park wrote: >>>> Change the reference of sleep_clk to the same as qcom-apq8064.dtsi. >>> >>> You add label, not change something. >>> >>>> >>>> Signed-off-by: Shinjo Park <peremen@gmail.com> >>>> Reviewed-by: David Heidelberg <david@ixit.cz> >>>> --- >>>> arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi >>>> index e8cd1c9c0..991eb1948 100644 >>>> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi >>>> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi >>>> @@ -71,7 +71,7 @@ pxo_board: pxo_board { >>>> clock-output-names = "pxo_board"; >>>> }; >>>> - sleep_clk { >>>> + sleep_clk: sleep_clk { >>> >>> Since you touch the line, make the device node sleep-clk (device node >>> names should not have underscores) and mention this in commit msg. >> >> >> Then we are back to the compat issues, since the gcc expects the 'sleep_clk' clock. > clock-output-names = "sleep_clk";
Ack then. Didn't notice that msm8960 has one.
-- With best wishes Dmitry
| |