Messages in this thread | | | Date | Fri, 29 Jul 2022 09:39:19 +0200 | Subject | Re: [PATCH linux dev-5.15] soc: aspeed: abr: Add sysfs attrs for flash toggle | From | Cédric Le Goater <> |
| |
Hello,
On 7/29/22 04:37, Andrew Jeffery wrote: > Hi Jian Zhang, > > On Sun, 1 May 2022, at 20:26, Jian Zhang wrote: >> Implement the flash toggle function in soc ast2600. >> Add two sysfs attrs named "access_primary" and "access_backup" > > If you're proposing this patch for upstream then it needs to be based on > an upstream kernel tree, not the OpenBMC kernel tree. You also should > not use e.g. `linux dev-5.15` in the patch subject prefix, as that would > be inappropriate for an upstream patch. > > As you're adding sysfs attributes you'll also need to add the > corresponding ABI documentation.
Yes. I think we need to discuss the ABI/sysfs files a bit. I am not sure we should toggle the sysfs files depending on the boot mode : primary vs. alternate. We could have the same files always and return EIO if some conditions are not met. Something like :
* boot mode : primary/alternate. Write changes the next boot. * watchdog management
Also, there is no need to introduce a new include file with large inline functions.
Thanks,
C.
| |