Messages in this thread | | | From | Subbaraya Sundeep Bhatta <> | Subject | Re: [net PATCH] octeontx2-pf: Reduce minimum mtu size to 60 | Date | Fri, 29 Jul 2022 09:33:03 +0000 |
| |
Hi Andrew,
Added PTP maintainer also in v2. We fixed this to work with latest ptp4l since after debugging we found ptp4l complains bad message for Sync packets. Lets hear from Richard.
Thanks, Sundeep
________________________________________ From: Andrew Lunn <andrew@lunn.ch> Sent: Friday, July 29, 2022 3:27 AM To: Naveen Mamindlapalli Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri Goutham; Subbaraya Sundeep Bhatta Re: [net PATCH] octeontx2-pf: Reduce minimum mtu size to 60
---------------------------------------------------------------------- On Thu, Jul 28, 2022 at 06:08:12PM +0530, Naveen Mamindlapalli wrote: > From: Subbaraya Sundeep <sbhatta@marvell.com> > > PTP messages like SYNC, FOLLOW_UP, DELAY_REQ are of size 58 bytes. > Using a minimum packet length as 64 makes NIX to pad 6 bytes of > zeroes while transmission. This is causing latest ptp4l application to > emit errors since length in PTP header and received packet are not same. > Padding upto 3 bytes is fine but more than that makes ptp4l to assume > the pad bytes as a TLV. Hence reduce the size to 60 from 64.
Please Cc: the PTP maintainer for changes like this.
I also don't follow your explanation. At least for the original 802.3, you had to pad packets shorter than 64 bytes, otherwise CSMA/CD did not work. So i would expect PTP messages should be padded to 64?
Or is you hardware doing the padding wrong, and this is a workaround for that bug?
Andrew
| |