lkml.org 
[lkml]   [2022]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2 4/5] staging: vt6655: Replace MACvTransmit0 with function vt6655_mac_dma_ctl
    Convert macro MACvTransmit0 to existing static function. This saves
    codelines and multiline macros are not liked by kernel community.

    Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
    ---
    V1 -> V2: Improved description
    ---
    drivers/staging/vt6655/device_main.c | 2 +-
    drivers/staging/vt6655/mac.h | 10 ----------
    2 files changed, 1 insertion(+), 11 deletions(-)

    diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
    index 554531411dad..c0a00063e4d1 100644
    --- a/drivers/staging/vt6655/device_main.c
    +++ b/drivers/staging/vt6655/device_main.c
    @@ -1231,7 +1231,7 @@ static int vnt_tx_packet(struct vnt_private *priv, struct sk_buff *skb)
    if (head_td->td_info->flags & TD_FLAGS_NETIF_SKB)
    MACvTransmitAC0(priv->port_offset);
    else
    - MACvTransmit0(priv->port_offset);
    + vt6655_mac_dma_ctl(priv->port_offset, MAC_REG_TXDMACTL0);

    priv->iTDUsed[dma_idx]++;

    diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
    index 5a473ca393f2..be33da59dd84 100644
    --- a/drivers/staging/vt6655/mac.h
    +++ b/drivers/staging/vt6655/mac.h
    @@ -537,16 +537,6 @@

    /*--------------------- Export Macros ------------------------------*/

    -#define MACvTransmit0(iobase) \
    -do { \
    - unsigned long dwData; \
    - dwData = ioread32(iobase + MAC_REG_TXDMACTL0); \
    - if (dwData & DMACTL_RUN) \
    - iowrite32(DMACTL_WAKE, iobase + MAC_REG_TXDMACTL0); \
    - else \
    - iowrite32(DMACTL_RUN, iobase + MAC_REG_TXDMACTL0); \
    -} while (0)
    -
    #define MACvTransmitAC0(iobase) \
    do { \
    unsigned long dwData; \
    --
    2.37.1
    \
     
     \ /
      Last update: 2022-07-29 10:16    [W:2.608 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site