lkml.org 
[lkml]   [2022]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/2] ufs: core: print UFSHCD capabilities in controller's sysfs node
    On Fri, Jul 29, 2022 at 12:05:08PM +1000, Daniil Lunev wrote:
    > Allows userspace to check if Clock Scaling, Write Booster and Inline
    > Crypto Engine functionality can be enabled.
    >
    > Signed-off-by: Daniil Lunev <dlunev@chromium.org>
    >
    > ---
    >
    > Changes in v3:
    > * Expose each capability individually.
    > * Update documentation to represent new scheme.
    >
    > Changes in v2:
    > * Add documentation entry for the new sysfs node.
    >
    > Documentation/ABI/testing/sysfs-driver-ufs | 39 ++++++++++++++++++++
    > drivers/ufs/core/ufs-sysfs.c | 41 ++++++++++++++++++++++
    > 2 files changed, 80 insertions(+)
    >
    > diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs
    > index 6b248abb1bd71..805d76f7d7aef 100644
    > --- a/Documentation/ABI/testing/sysfs-driver-ufs
    > +++ b/Documentation/ABI/testing/sysfs-driver-ufs
    > @@ -1591,6 +1591,45 @@ Description: This entry shows the status of HPB.
    >
    > The file is read only.
    >
    > +What: /sys/bus/platform/drivers/ufshcd/*/capabilities/clock_scaling

    This shouldn't be linked to as a driver file, it's a device file. So no
    need for this line.

    > +What: /sys/bus/platform/devices/*.ufs/capabilities/clock_scaling

    Since when are all ufs devices platform devices? Do we not have UFS
    controllers on other types of busses?

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2022-07-29 10:12    [W:4.674 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site