Messages in this thread | | | Date | Thu, 28 Jul 2022 16:14:37 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v3 00/30] Add generated latest Intel events and metrics |
| |
Em Wed, Jul 27, 2022 at 03:08:02PM -0700, Ian Rogers escreveu: > The goal of this patch series is to align the json events for Intel > platforms with those generated by: > https://github.com/intel/event-converter-for-linux-perf/blob/master/download_and_gen.py > This script takes the latest event json and TMA metrics from: > https://download.01.org/perfmon/ and adds to these metrics, in > particular uncore ones, from: https://github.com/intel/perfmon-metrics > > Some fixes were needed to the script for generating the json and are > contained in this pull request: > https://github.com/intel/event-converter-for-linux-perf/pull/15 > > The json files were first downloaded before being used to generate the > perf json files. This fixes non-ascii characters for (R) and (TM) in > the source json files. This can be reproduced with: > $ download_and_gen.py --hermetic-download --outdir data > $ download_and_gen.py --url=file://`pwd`/data/01 --metrics-url=file://`pwd`/data/github > > A minor correction is made in the generated json of: > tools/perf/pmu-events/arch/x86/ivytown/uncore-other.json > changing "\\Inbound\\" to just "Inbound" to avoid compilation errors > caused by \I. > > The elkhartlake metrics file is basic and not generated by scripts. It > is retained here although it causes a difference from the generated > files. > > The mapfile.csv is the third and final difference from the generated > version due to a bug in 01.org's models for icelake. The existing > models are preferred and retained. > > Compared to the previous json, the major changes are: > - the inclusion of basic meteorlake events, > - the inclusion of server uncore metrics, > - the inclusion of previously ungenerated and experimental uncore events. > > v3. Rebase on top of Zhengjun Xing's updates. Remove merged test fix > and tremontx rename patches.
Thanks, applied.
- Arnaldo
| |