Messages in this thread | | | Date | Thu, 28 Jul 2022 15:38:54 +0200 | Subject | Re: [PATCH v2 1/2] dt-binding: iio: time: add capture-tiecap.yaml | From | Krzysztof Kozlowski <> |
| |
On 28/07/2022 14:52, Julien Panis wrote: > This commit adds a YAML binding for TI ECAP used in capture operating mode. > > Signed-off-by: Julien Panis <jpanis@baylibre.com> > --- > .../bindings/iio/time/capture-tiecap.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml > > diff --git a/Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml b/Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml > new file mode 100644 > index 000000000000..5d66df90ba5d > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/time/capture-tiecap.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/time/capture-tiecap.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml#
Still wrong file name.
Do not ignore comments you received. Either you implement them or you keep the discussion going.
> + > +title: Texas Instruments Enhanced Capture (eCAP) Module > + > +maintainers: > + - Julien Panis <jpanis@baylibre.com> > +
(...)
> + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/soc/ti,sci_pm_domain.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + bus@f0000 { > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x00 0x20000000 0x00 0x20000000 0x00 0x0a008000>;
A bit too many nodes. Just keep one, bus or soc. Look at other examples.
Best regards, Krzysztof
| |