lkml.org 
[lkml]   [2022]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ufs: core: print capabilities in controller's sysfs node
From
On 7/27/22 21:49, Daniil Lunev wrote:
> +static ssize_t caps_show(struct device *dev, struct device_attribute *attr,
> + char *buf)
> +{
> + struct ufs_hba *hba = dev_get_drvdata(dev);
> +
> + return sysfs_emit(buf, "0x%08llx\n", hba->caps);
> +}

This code change includes all of the UFSHCD_CAP_* constants in the
kernel ABI. Is that really what we want? I'm wondering whether it
perhaps would be better only to export those capabilities to user space
that user space needs to know about.

Thanks,

Bart.

\
 
 \ /
  Last update: 2022-07-28 15:38    [W:0.052 / U:2.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site