Messages in this thread | | | Date | Thu, 28 Jul 2022 15:12:10 +0200 | From | Michael Walle <> | Subject | Re: [PATCH 1/2] mtd: spi-nor: introduce SNOR_ID3() |
| |
>>> +#define SNOR_ID3(_jedec_id) > > How about SFDP_ID3 and SFDP_ID6 instead?
Yes, probably a better name. I was also thinking about splitting the id in vendor, device and additional bytes. But I haven't thought of the actual implementation that much. Such as:
#define SFDP_ID(<u8 vid>, <u16 did>, <variable aux bytes>) #define SFDP_ID_FULL(<num_continuation_code>, <u8 vid>, <u16 did>, <variable aux bytes>)
Couldn't make up a better name than that _FULL for now. Happy to hear suggestions :)
-michael
| |