lkml.org 
[lkml]   [2022]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] xfs: fix NULL pointer dereference in xfs_getbmap()
From
在 2022/7/27 23:16, Darrick J. Wong 写道:

> Heh. Is this worth an fstest? It probably is, since prior to 5.20 this
> would have been a UAF bug on top of a NULL deref.

I will try to add regression test to xfstests for this commit when it is
merged into mainline.

>
> Nit: it's ILOCK, not i_lock. Otherwise... this looks correct to me --
> take the IOLOCK and ILOCK in shared mode before accessing the inode fork
> structures.
>
> Do you have any suggestions for Fixes:? I suspect this has been broken
> for quite some time.

The "Fixes:" label is: abbf9e8a4507 ("xfs: rewrite getbmap using the
xfs_iext_* helpers")

>
> No need to fix the nit, I'll do that when I commit this.
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> --D
>

\
 
 \ /
  Last update: 2022-07-28 13:00    [W:0.052 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site